Dennis Hackethal
@dennis-hackethal·Member since June 2024
Activity
This problem will surface rarely – users would have to hit cmd + f immediately upon opening the page. For most users, by the time they start typing, the page is already fully loaded. So this seems like a small price to pay in exchange for discussion pages that always render faster.
Now that parts of the page are purposely and visually disabled (see #2694), users may not expect everything to be working 100% during a loading state.
#2671·Dennis HackethalOP, about 1 month agoJS modules are always deferred and unusable until the page is fully loaded. As a result, comment buttons and gutters won’t work while ideas are still streaming onto the page.
I now purposely prevent interactions with buttons and gutters, and gray them out, until the page is fully loaded. So instead of broken hover effects and interactions, the user gets intentionally disabled elements, and this intentionality is communicated to them.
Once the page is fully loaded, buttons and gutters are enabled and visually restored.
Since the browser’s loading indicator remains visible until then, this behavior shouldn’t violate user expectation.
#2692·Dennis HackethalOP, about 1 month agoI could override
authenticate_user!in theDiscussionsController.
That means duplicate functionality; anytime I customize Devise in the future, I’ll have to remember to adjust this one method as well.
#2670·Dennis HackethalOP, about 1 month agoIncompatible with Devise authentication: https://github.com/heartcombo/devise/issues/2332
I could override authenticate_user! in the DiscussionsController.
#2670·Dennis HackethalOP, about 1 month agoIncompatible with Devise authentication: https://github.com/heartcombo/devise/issues/2332
I could extract discussions#show into a new, separate StreamController or something like it. That controller would not use Devise.
#2688·Dennis HackethalOP revised about 1 month agoThe thread suggests a workaround: use
authenticated do …blocks inroutes.rbinstead ofbefore_action :authenticate_user!in controllers.It’s probably a good idea to do this anyway to avoid divulging the existence of routes that unauthenticated users don’t need to know exist. (They will get a 404 instead of a 401.)
Then again, I’d want to redirect users to the sign-in page (and then ideally back to where they were trying to go).
The thread suggests solution: use authenticated do … blocks in routes.rb instead of before_action :authenticate_user! in controllers.
It’s probably a good idea to do this anyway to avoid divulging the existence of routes that unauthenticated users don’t need to know exist. (They will get a 404 instead of a 401.)
The thread suggests a workaround: use authenticated do … blocks in routes.rb instead of before_action :authenticate_user! in controllers.
It’s probably a good idea to do this anyway to avoid divulging the existence of routes that unauthenticated users don’t need to know exist. (They will get a 404 instead of a 401.)
The thread contains a suggested solution: use authenticated do … blocks in routes.rb instead of before_action :authenticate_user! in controllers.
It’s probably a good idea to do this anyway to avoid divulging the existence of routes that unauthenticated users don’t need to know exist. (They will get a 404 instead of a 401.)
The thread suggests solution: use authenticated do … blocks in routes.rb instead of before_action :authenticate_user! in controllers.
It’s probably a good idea to do this anyway to avoid divulging the existence of routes that unauthenticated users don’t need to know exist. (They will get a 404 instead of a 401.)
#2636·Dennis HackethalOP, about 1 month agoOn initial page load, I could just load the first ten or so top-level ideas and their immediate children, just to reduce wait times and populate the page. Then load the rest asynchronously.
#2677·Dennis HackethalOP, about 1 month agoThe top level ideas could be rendered as turbo frames of
ideas#show.
While ideas load, cmd +f won’t work.
#2680·Dennis HackethalOP, about 1 month agoI just tried this. Seemed promising at first but sometimes ideas load out of order. Looks horrible.
I could render the first ~10 top-level ideas immediately and only render the rest as turbo frames off screen. By the time the user scrolls down, they should all be loaded.
#2676·Dennis HackethalOP, about 1 month agoFor large discussions, wouldn’t that flood the server with requests?
#2677·Dennis HackethalOP, about 1 month agoThe top level ideas could be rendered as turbo frames of
ideas#show.
Too many requests when there are enough top-level ideas.
#2677·Dennis HackethalOP, about 1 month agoThe top level ideas could be rendered as turbo frames of
ideas#show.
I just tried this. Seemed promising at first but sometimes ideas load out of order. Looks horrible.
#2659·Dennis HackethalOP revised about 1 month agoI could use
ActionController::Liveto stream top-level ideas to the page one by one. Instant page load.
cmd + f won’t work reliably.
#2635·Dennis HackethalOP, about 1 month agoI could lazy load ideas: only load the parts of the page that would be visible on the current viewport. Then load more parts as the user scrolls.
That means cmd + f won’t always work.
#2630·Dennis HackethalOP revised about 1 month agoDiscussions are getting slower to render as they grow. It’s a rendering issue (not a db issue).
The top level ideas could be rendered as turbo frames of ideas#show.
#2675·Dennis HackethalOP, about 1 month agoI could have a separate route at
/ideas/:id/isolatedwhich renders only the idea without any parents or children. And then a discussion could render a bunch of deeply nested turbo frames loading that route.
For large discussions, wouldn’t that flood the server with requests?
#2630·Dennis HackethalOP revised about 1 month agoDiscussions are getting slower to render as they grow. It’s a rendering issue (not a db issue).
I could have a separate route at /ideas/:id/isolated which renders only the idea without any parents or children. And then a discussion could render a bunch of deeply nested turbo frames loading that route.
The thread contains a suggested solution: use authenticated do … blocks in routes.rb instead of before_action :authenticate_user! in controllers.
The thread contains a suggested solution: use authenticated do … blocks in routes.rb instead of before_action :authenticate_user! in controllers.
It’s probably a good idea to do this anyway to avoid divulging the existence of routes that unauthenticated users don’t need to know exist. (They will get a 404 instead of a 401.)
#2670·Dennis HackethalOP, about 1 month agoIncompatible with Devise authentication: https://github.com/heartcombo/devise/issues/2332
The thread contains a suggested solution: use authenticated do … blocks in routes.rb instead of before_action :authenticate_user! in controllers.
#2659·Dennis HackethalOP revised about 1 month agoI could use
ActionController::Liveto stream top-level ideas to the page one by one. Instant page load.
JS modules are always deferred and unusable until the page is fully loaded. As a result, comment buttons and gutters won’t work while ideas are still streaming onto the page.
#2659·Dennis HackethalOP revised about 1 month agoI could use
ActionController::Liveto stream top-level ideas to the page one by one. Instant page load.
Incompatible with Devise authentication: https://github.com/heartcombo/devise/issues/2332
Feature idea: pay people to address criticisms (either revise an idea and check off criticisms or counter-criticize).