Hiccdown Development Notes

Dennis Hackethal started this discussion over 1 year ago·Show active ideas

Notes about developing the Ruby gem Hiccdown.

  Log in or sign up to participate in this discussion.
With an account, you can revise, criticize, and comment on ideas, and submit new ideas.

  Top-level ideas are archived automatically if they have pending criticisms after about 1 month of inactivity. New comments and revisions ‘revive’ them.
Discussions can branch out indefinitely. Zoom out for the bird’s-eye view.
Dennis Hackethal’s avatar
Dennis HackethalOP revised about 1 month ago·#1978

Hiccdown methods should live in Rails helpers as instance methods.

CriticismCriticized1oustanding criticism
Dennis Hackethal’s avatar
Dennis HackethalOP, over 1 year ago·#301

That isn’t a good idea because Hiccdown methods often share the same conventional names (index, show, etc), which can and does lead to conflict.

Criticism of #1978
Dennis Hackethal’s avatar
Dennis HackethalOP revised about 1 month ago·#1980

Hiccdown methods should live in Rails helpers as class methods. That way, the problem described in #302 is solved – methods can be referenced unambiguously:

ProductsHelper.index
StoresHelper.index
CriticismCriticized2oustanding criticisms
Dennis Hackethal’s avatar
Dennis HackethalOP revised over 1 year ago·#305

Does that mean they wouldn’t have access to the view_context? If so, calling helper methods from inside these class methods wouldn’t be possible.

Criticism of #1980Criticized1oustanding criticism
Dennis Hackethal’s avatar
Dennis HackethalOP revised over 1 year ago·#310

If so, there might be a way to bind them to the view_context. Or I could definitely pass the view_context explicitly as the first parameter:

So instead of

@helper_module.instance_method(@action_name).bind_call(view_context)

I would do

@helper_module.send(@action_name, view_context)

And the parameter list of each Hiccdown method would start accordingly:

module ProductsHelper
  def self.index vc #, …
    vc.some_helper_method
  end

  def some_helper_method
    # …
  end
end
Criticism of #305
Dennis Hackethal’s avatar
Dennis HackethalOP, over 1 year ago·#312

That would be mixing class methods an instance methods in Rails helper modules, which typically only contain instance methods. Not idiomatic Rails usage.

Criticism of #1980
Dennis Hackethal’s avatar
Dennis HackethalOP, over 1 year ago·#332

#327 applies here, too: no access to instance variables inside helper class methods.

Criticism of #1980