Hiccdown Development Notes

Showing only #330 and its comments.

See full discussion

Log in or sign up to participate in this discussion.

With an account, you can revise, criticize, and comment on ideas.

Discussions can branch out indefinitely. Zoom out for the bird’s-eye view.

Dennis HackethalOP·#330

4th of 5 versions

Hiccdown methods should live in their own, separate classes. How about they are called ‘displays’?

1
2
3
4
5
ruby
class ProductsDisplay
  def index vc, # …
    vc.some_helper_method
  end
end

Behind the scenes, the Hiccdown gem would need to make the instance variables available to the display class:

1
2
3
4
5
6
7
8
ruby
display = @display_module.new

view_context.instance_variables.each do |iv|
  display.instance_variable_set(
    iv,
    view_context.instance_variable_get(iv)
  )
end

Then:

1
2
3
4
5
ruby
class ProductsDisplay
  def index vc, # …
    vc.some_helper_method(@products)
  end
end

Criticized2Archived

Dennis HackethalOP·#317

2nd of 2 versions

Then how would you call index from a helper method?

Criticism of #330Criticized1

Dennis HackethalOP·#315

I don’t think that’s something people would do a lot, but they still easily could: ProductsRenderer.index(self)

Criticism of #317

Dennis HackethalOP·#321

Test this!

Criticism of #315Criticized1

Dennis HackethalOP·#323

2nd of 2 versions

Tested, it works. self does indeed point to the view_context in the helper. Verified by printing object_ids.

Criticism of #321

Dennis HackethalOP·#331

Not as of #330, they couldn’t.

Criticism of #315Criticized1

Dennis HackethalOP·#341

It doesn’t really matter. This would be like calling a controller action from a helper method. Not something people do.

Criticism of #331

Dennis HackethalOP·#326

I’m trying this now. Having to prepend every invocation of a helper method with vc. is getting really old really fast.

Criticism of #330

Dennis HackethalOP·#1983

Superseded by #1982. This comment was generated automatically.

Criticism of #330