Activity

  Dennis Hackethal addressed criticism #3951.

Done as of cc1ab95.

Ruby example:

ruby
def criticized? idea
pending_criticisms(idea).any?
end
def pending_criticisms idea
criticisms(idea).filter { |c| pending_criticisms(c).none? }
end
def criticisms idea
children(idea).filter(&:criticism?)
end

JS example (h/t ChatGPT):

javascript
function criticized(idea) {
return pendingCriticisms(idea).length > 0;
}
function pendingCriticisms(idea) {
return criticisms(idea).filter(c => pendingCriticisms(c).length === 0);
}
function criticisms(idea) {
return children(idea).filter(c => c.isCriticism);
}
#3951·Dennis HackethalOP, 7 days ago

The diff view can’t handle the removal/replacement of entire code blocks yet. The removed block looks broken, the new block doesn’t show at all.