Veritula – Meta

Showing only ideas leading to #5703 and its comments.

See full discussion·See most recent related ideas

Log in or sign up to participate in this discussion.

With an account, you can revise, criticize, and comment on ideas.

Discussions can branch out indefinitely. You may need to scroll sideways.

Dennis HackethalOP·#3950·8mo

Code blocks need syntax highlighting.

Veritula used to have this feature but I removed it when diffing changed.

CriticismCriticized1*Archived

Dennis HackethalOP·#5703·23h

2nd of 2 versions

Done as of 65dba4b.

Ruby example:

1
2
3
4
5
6
7
8
9
10
11
ruby
def criticized? idea
  pending_criticisms(idea).any?
end

def pending_criticisms idea
  criticisms(idea).filter { |c| pending_criticisms(c).none? }
end

def criticisms idea
  children(idea).filter(&:criticism?)
end

JS example (h/t ChatGPT):

1
2
3
4
5
6
7
8
9
10
11
javascript
function criticized(idea) {
  return pendingCriticisms(idea).length > 0;
}

function pendingCriticisms(idea) {
  return criticisms(idea).filter(c => pendingCriticisms(c).length === 0);
}

function criticisms(idea) {
  return children(idea).filter(c => c.isCriticism);
}

Criticism of #3950 Battle-testedArchived

Dennis HackethalOP·#3956·8mo

2nd of 2 versions

When an idea has nothing but a code block, there’s too much of a margin at the bottom, between the block and the border of the highlight.

Criticism of #5703Criticized1Archived

Dennis HackethalOP·#3954·8mo

Fixed as of a44c6c0.

Criticism of #3956Archived

Dennis HackethalOP·#4013·8mo

There’s a small issue related to previewing changes in code blocks: even when there are no changes yet, if the code overflows horizontally, the scroll shadow is shown through DOM manipulation, which in turn triggers the diffing library into thinking the user made a change.

So then the same code block is shown without any changes, under the ‘Changes’ tab, which is confusing. It should still just say ‘No changes’.

Criticism of #5703Criticized1Archived

Dennis HackethalOP·#5702·1d

Fixed as of 7134d27.

Criticism of #4013Archived

Dennis HackethalOP·#4016·8mo

There’s an issue with horizontal scroll for overflowing code blocks in the activity feed on mobile. Can’t scroll all the way to the right.

Criticism of #5703Criticized1Archived

Dennis HackethalOP·#4022·8mo

Fixed as of e49cd8d.

Criticism of #4016Archived

Dennis HackethalOP·#4023·8mo

Would be nice if the copy button was sticky-top so that it scrolled with the user.

Criticism of #5703Criticized1Archived

Dennis HackethalOP·#5731·8h·AI-assisted

2nd of 2 versions

A sticky button can't work here: the main content area has to be a horizontal scroll container so deeply nested trees can grow sideways, and that stops position: sticky from sticking. The workarounds (reworking the global layout, or JavaScript positioning that jitters on mobile) are too risky for such a small benefit.

Criticism of #4023Archived

Dennis HackethalOP·#4032·8mo

Done as of 43c4ecc.

Criticism of #4023Criticized1Archived

Dennis HackethalOP·#4033·8mo

I spoke to soon. Rolling this back for now. Too jittery when scrolling on mobile. Non-trivial to implement. Need to see how other sites do it.

Criticism of #4032Archived

Dennis HackethalOP·#4024·8mo

2nd of 2 versions

The diff view can’t handle the removal/replacement of entire code blocks yet. The removed block looks broken, the new block doesn’t show at all. See activity 3207 in dev.

Criticism of #5703Criticized1Archived

Dennis HackethalOP·#5701·1d

Fixed as of b2a2a32 at the latest.

Criticism of #4024Archived

Dennis HackethalOP·#4027·8mo

2nd of 2 versions

On mobile, there needs to be more of a padding on the right, inside the code block.

Criticism of #5703Criticized1Archived

Dennis HackethalOP·#4029·8mo

Done as of 609b5c3.

Criticism of #4027Archived