Veritula – Meta

Showing only #3950 and its comments.

See full discussion

Log in or sign up to participate in this discussion.

With an account, you can revise, criticize, and comment on ideas.

Discussions can branch out indefinitely. You may need to scroll sideways.

Dennis HackethalOP·#3950·9mo·Criticism

Code blocks need syntax highlighting.

Veritula used to have this feature but I removed it when diffing changed.

Criticized1Archived

Dennis HackethalOP·#5703·23d·Criticism

2nd of 2 versions

Done as of 65dba4b.

Ruby example:

1
2
3
4
5
6
7
8
9
10
11
ruby
def criticized? idea
  pending_criticisms(idea).any?
end

def pending_criticisms idea
  criticisms(idea).filter { |c| pending_criticisms(c).none? }
end

def criticisms idea
  children(idea).filter(&:criticism?)
end

JS example (h/t ChatGPT):

1
2
3
4
5
6
7
8
9
10
11
javascript
function criticized(idea) {
  return pendingCriticisms(idea).length > 0;
}

function pendingCriticisms(idea) {
  return criticisms(idea).filter(c => pendingCriticisms(c).length === 0);
}

function criticisms(idea) {
  return children(idea).filter(c => c.isCriticism);
}

Battle-testedArchived

Dennis HackethalOP·#3956·9mo·Criticism

2nd of 2 versions

When an idea has nothing but a code block, there’s too much of a margin at the bottom, between the block and the border of the highlight.

Criticized1Archived

Dennis HackethalOP·#4013·9mo·Criticism

There’s a small issue related to previewing changes in code blocks: even when there are no changes yet, if the code overflows horizontally, the scroll shadow is shown through DOM manipulation, which in turn triggers the diffing library into thinking the user made a change.

So then the same code block is shown without any changes, under the ‘Changes’ tab, which is confusing. It should still just say ‘No changes’.

Criticized1Archived

Dennis HackethalOP·#4016·9mo·Criticism

There’s an issue with horizontal scroll for overflowing code blocks in the activity feed on mobile. Can’t scroll all the way to the right.

Criticized1Archived

Dennis HackethalOP·#3952·9mo

When the code overflows horizontally, a subtle inset shadow on the side shows that you can scroll:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
javascript
const posts = [
  {id: 1, title: "Understanding JavaScript Closures in Depth", url: "https://example.com/articles/javascript-closures-deep-dive"},
  {id: 2, title: "A Complete Guide to Modern Web Development Practices", url: "https://example.com/articles/modern-web-dev-guide"},
  {id: 3, title: "Exploring the Node.js Event Loop and Async Patterns", url: "https://example.com/articles/nodejs-event-loop"}
];

function formatPost(post) {
  return `${post.id}: ${post.title} -> ${post.url}`;
}

function prettyPrint(posts) {
  return posts.map(formatPost).join(" | ");
}

console.log(prettyPrint(posts));

Archived

🤩