Veritula – Meta
Showing only #2970 and its comments.
See full discussionLog in or sign up to participate in this discussion.
With an account, you can revise, criticize, and comment on ideas.
Bug when cycling through ‘filtered’ revisions: on page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea is shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
For all ideas, the total number of pending criticisms (if any) should always be shown, even if they are not all being rendered. For filtered parents, I could put an asterisk behind the count. On hover, explain that some pending criticisms may be hidden due to filtering.
Any filtered idea should always display only the count of shown criticisms.
As with #2098, implementing an accurate count of the number of shown criticisms gets very tricky once the user starts submitting new criticisms on filtered parents.
That could mislead people into thinking a revision has no pending criticisms, which would be bad for error correction.
The instructions at the top of the page are clear that not all ideas are being rendered.
People could easily miss or forget that.
For filtered parents, I could put an asterisk behind the count. On hover, explain that the total number of pending criticisms may be greater on the unfiltered view.
Any filtered ideas should show a criticism label displaying n / m for the count, where n is the number of rendered criticisms and m is the number of total criticisms.
An explanation could accompany the n / m display, like a title on hover.
That way, there should never be any confusion as to a mismatch between the total vs rendered number of pending criticisms.
In addition, when looking at a deeply nested idea on ideas#show and submitting a criticism on a parent, I need to make sure the updated badges take into account that newly submitted criticism, even though the new criticism would not show after refreshing the page.
I have this working to the point that it shows n / m, but getting the counter to update properly when new criticisms are posted on filtered parents is surprisingly difficult – so difficult the juice may not be worth the squeeze.
For any filtered parent, the criticism badge could be shown without a count.
I could get rid of the count everywhere, even on unfiltered views. That would have the added benefit that users wouldn’t prefer one problematic idea over another just because it has fewer pending criticisms.
Still, the count is valuable in that it shows how many criticisms need to be addressed to restore an idea.