Activity
For all ideas, the total number of pending criticisms (if any) should always be shown, even if they are not all being rendered.
For all ideas, the total number of pending criticisms (if any) should always be shown, even if they are not all being rendered. For filtered parents, I could put an asterisk behind the count. On hover, explain that some pending criticisms may be hidden due to filtering.
A Society Guided by Reason
The same logic explained in #2281 and #2844 applies to ideas across people as well. A free market or free society, by definition, is one where all interactions are based on unanimous consent.
One difference between the market and individuals is freedom of association. For example, when people disagree, they can just go their separate ways. But a single man cannot do that when parts of him disagree; a single man cannot dissociate from himself.
This difference does not change the overall desirability of unanimous consent both within and across minds. It’s an ‘implementation detail’.
#2008·Dennis HackethalOP revised about 2 months agoAny filtered idea should always display only the count of shown criticisms.
As with #2098, implementing an accurate count of the number of shown criticisms gets very tricky once the user starts submitting new criticisms on filtered parents.
For filtered parents, I could put an asterisk behind the count. On hover, explain that the total number of pending criticisms may be greater on the unfiltered view.
For filtered parents, I could put an asterisk behind the count. On hover, explain that the total number of pending criticisms may be greater on the unfiltered view.
For filtered parents, I could put an asterisk behind the count. On hover, explain that some pending criticisms may be hidden due to filtering.
For filtered parents, I could put an asterisk behind the count. On hover, explain that the total number of pending criticisms may be greater on the unfiltered view.
#3005·Dennis HackethalOP revised 8 days agoI could get rid of the count everywhere, even on unfiltered views. That would have the added benefit that users wouldn’t prefer one problematic idea over another just because it has fewer pending criticisms.
Still, the count is valuable in that it shows how many criticisms need to be addressed to restore an idea.
I could get rid of the count everywhere, even on unfiltered views.
I could get rid of the count everywhere, even on unfiltered views. That would have the added benefit that users wouldn’t prefer one problematic idea over another just because it has fewer pending criticisms.
I could get rid of the count everywhere, even on unfiltered views.
Bug when cycling through ‘filtered’ revisions: on page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea is shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
The displayed criticism count for a filtered parent can differ from the number of displayed criticisms.
#2999·Dennis HackethalOP revised 9 days agoFor any filtered parent, the criticism badge could be shown without a count.
But users are expecting a count.
For any filtered parent, the criticism badge could be shown without any count.
For any filtered parent, the criticism badge could be shown without a count.
#2970·Dennis HackethalOP revised 10 days agoBug when cycling through ‘filtered’ revisions: on page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea is shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
For any filtered parent, the criticism badge could be shown without any count.
#2098·Dennis HackethalOP revised about 2 months agoAny filtered ideas should show a criticism label displaying
n / mfor the count, wherenis the number of rendered criticisms andmis the number of total criticisms.An explanation could accompany the
n / mdisplay, like a title on hover.That way, there should never be any confusion as to a mismatch between the total vs rendered number of pending criticisms.
In addition, when looking at a deeply nested idea on ideas#show and submitting a criticism on a parent, I need to make sure the updated badges take into account that newly submitted criticism, even though the new criticism would not show after refreshing the page.
I have this working to the point that it shows n / m, but getting the counter to update properly when new criticisms are posted on filtered parents is surprisingly difficult – so difficult the juice may not be worth the squeeze.
#2972·Dennis HackethalOP, 10 days agoBug: as you cycle through a parent’s versions on ideas#show, the children are suddenly not being filtered anymore, and the highlighted idea suddenly has siblings.
Done as of 27123bd.
Bug: as you cycle through a parent’s versions on ideas#show, the children are suddenly not being filtered anymore, and the highlighted idea suddenly has siblings.
Bugs when cycling through ‘filtered’ revisions:
- On page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea is shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
- As you cycle through the parent’s versions, the children are suddenly not being filtered anymore, and the highlighted idea suddenly has siblings. Now the criticism count on the parent does always match the number of shown criticisms, but it seems arbitrary to suddenly not filter the children anymore.
Bug when cycling through ‘filtered’ revisions: on page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea is shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
#2965·Dennis HackethalOP revised 10 days agoBugs when cycling through ‘filtered’ revisions:
- On page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea is shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
- As you cycle through the parent’s versions, the children are suddenly not being filtered anymore, and the highlighted idea suddenly has siblings. Now the criticism count on the parent does always match the number of shown criticisms, but it seems arbitrary to suddenly not filter the children anymore.
Shouldn’t have more than one criticism at a time.
Fix typos
That it and of itself isn’t a bug if the different revisions leading to the highlighted idea have different numbers of criticisms.
The issue also isn’t that there are other revisions that don’t lead to the highlighted idea.
The real issue is twofold:
- On page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
- As you cycle through the parent’s versions, the children are suddenly not being filtered anymore, and the highlighted idea suddenly has siblings. Now the criticism count on the parent does always match the number of shown criticisms, but it seems arbitrary to suddenly not filter the children anymore.
That in and of itself isn’t a bug if the different revisions leading to the highlighted idea have different numbers of criticisms.
The issue also isn’t that there are other revisions that don’t lead to the highlighted idea.
The real issue is twofold:
- On page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea is shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
- As you cycle through the parent’s versions, the children are suddenly not being filtered anymore, and the highlighted idea suddenly has siblings. Now the criticism count on the parent does always match the number of shown criticisms, but it seems arbitrary to suddenly not filter the children anymore.
Bug: when cycling through ‘filtered’ revisions (meaning there are more revisions that don’t lead to the highlighted idea), the criticism badge can change count for the same revision.
Bugs when cycling through ‘filtered’ revisions:
- On page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea is shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
- As you cycle through the parent’s versions, the children are suddenly not being filtered anymore, and the highlighted idea suddenly has siblings. Now the criticism count on the parent does always match the number of shown criticisms, but it seems arbitrary to suddenly not filter the children anymore.
#1986·Dennis HackethalOP revised about 2 months agoBug: when cycling through ‘filtered’ revisions (meaning there are more revisions that don’t lead to the highlighted idea), the criticism badge can change count for the same revision.
That it and of itself isn’t a bug if the different revisions leading to the highlighted idea have different numbers of criticisms.
The issue also isn’t that there are other revisions that don’t lead to the highlighted idea.
The real issue is twofold:
- On page render, no matter how many children/criticisms a parent of the highlighted idea has, only the highlighted idea shown – that’s fine so far – but the displayed criticism count may be higher if there are criticisms that are not being shown. So there’s a mismatch.
- As you cycle through the parent’s versions, the children are suddenly not being filtered anymore, and the highlighted idea suddenly has siblings. Now the criticism count on the parent does always match the number of shown criticisms, but it seems arbitrary to suddenly not filter the children anymore.
Simplify language
The red ‘Criticized’ label shows how many outstanding criticisms an idea has. For example ‘Criticized (5)’ means the idea has five outstanding criticisms.
But if there are lots of comments, including non-criticisms and addressed criticisms, it’s hard to identify outstanding criticisms.
There should be an easy way to filter comments of a given idea down to only outstanding criticisms.
The red ‘Criticized’ label shows how many pending criticisms an idea has. For example ‘Criticized (5)’ means the idea has five pending criticisms.
But if there are lots of comments, including non-criticisms and addressed criticisms, it’s hard to identify pending criticisms.
There should be an easy way to filter comments of a given idea down to only pending criticisms.